fix: PodMonitor #2921
Open
fix: PodMonitor #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kariya-mitsuru. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
requested changes
Feb 11, 2025
| @@ -50,7 +50,7 @@ spec: | |||
| resources: {{- toYaml .Values.crdReplicator.pod.resources | nindent 12 }} | |||
| ports: | |||
| - name: metrics | |||
| containerPort: 8082 | |||
There was a problem hiding this comment.
Hi @kariya-mitsuru, thanks for your PR. Can you keep the "8082" port and add a flag inside the CRD replicator to set the port, please?
Could you edit /cmd/crd-replicator/main.go.
Check this
liqo/cmd/liqo-controller-manager/main.go
Line 106 in c2f889a
* crd-replicator Commit 10ef308 changed the default port for metrics from 8080 to 8082, but crd-replicator was not changed because there is no command line option. However, only the deployment port was changed to 8082, so PodMonitor no longer works properly. This commit adds the command line option, which defaults to 8082. * virtualkubelet Commit ddafea0 changed the label of VirtualKubelet but did not change the PodMonitor selector so it no longer works correctly. This commit makes PodMonitor's selector follow commit ddafea0. Signed-off-by: Mitsuru Kariya <[email protected]>
kariya-mitsuru
force-pushed
the
fix-pmon
branch
from
6f16407 to
b3055e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
PodMonitor.crd-replicator
Commit 10ef308 changed the default port for metrics from
8080to8082, but crd-replicator was not changed because there is no command line option. However, only theDeploymentport was changed to 8082, soPodMonitorno longer works properly.This commit reverts the
Deploymentport back to8080.VirtualKubelet
Commit ddafea0 changed the label of VirtualKubelet but did not change the
PodMonitorselector so it no longer works correctly.This commit makes
PodMonitor's selector follow commit ddafea0.